Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Intermittent failures for the KL Divergence GTests #716

Closed
cjnolet opened this issue Jun 16, 2022 · 5 comments
Closed

[BUG] Intermittent failures for the KL Divergence GTests #716

cjnolet opened this issue Jun 16, 2022 · 5 comments
Labels
bug Something isn't working inactive-30d

Comments

@cjnolet
Copy link
Member

cjnolet commented Jun 16, 2022

This has popped up several times now in CI and I've yet to see these locally. The first couple times I saw it, I thought maybe it was just a fluke but now it's happened enough times that it's worth investigating the cause.
@cjnolet cjnolet added the bug Something isn't working label Jun 16, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Jun 17, 2022

Here's an example of the failure in CI.

https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/raft/job/prb/job/raft-gpu-test/CUDA=11.0,GPU_LABEL=driver-450,LINUX_VER=centos7,PYTHON=3.8/1556/console

cc @mdoijade

@mdoijade
Copy link
Contributor

Thanks for informing, I'm work towards fixing this, from log file seems like naive test kernel has a bug whereas main kernel is generating correct output.

@mdoijade mdoijade mentioned this issue Jun 24, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 24, 2022
@mdoijade
fix nans in naive kl divergence kernel introduced by div by 0. (#724)
5240ab3 
-- This address issue #716
-- remove redundant commented code as well.

Authors:
  - Mahesh Doijade (https://github.com/mdoijade)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #724
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@mdoijade
Copy link
Contributor

this issue is fixed, should be good to close this.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working inactive-30d
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cjnolet @viclafargue @mdoijade