Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving kmeans from cuml to Raft #605

Merged
merged 37 commits into from
Jul 26, 2022
Merged

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Mar 31, 2022

This PR replace the current KMeans of Raft with cuml's implementation.
Closes #28.
It is using the new device_*_view for the API.

@github-actions github-actions bot added the cpp label Mar 31, 2022
@github-actions github-actions bot added the CMake label Apr 4, 2022
@lowener lowener marked this pull request as ready for review April 22, 2022 12:16
@lowener lowener requested review from a team as code owners April 22, 2022 12:16
@lowener lowener added 3 - Ready for Review breaking Breaking change improvement Improvement / enhancement to an existing function labels Apr 24, 2022
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is looking great so far. Most of my comments are related to small API things.

cpp/include/raft/cluster/detail/kmeans.cuh Outdated Show resolved Hide resolved
cpp/include/raft/cluster/detail/kmeans.cuh Show resolved Hide resolved
cpp/include/raft/cluster/detail/kmeans.cuh Outdated Show resolved Hide resolved
cpp/include/raft/cluster/detail/kmeans.cuh Outdated Show resolved Hide resolved
cpp/include/raft/cluster/detail/kmeans.cuh Outdated Show resolved Hide resolved
cpp/test/cluster/kmeans.cu Outdated Show resolved Hide resolved
cpp/include/raft/cluster/detail/kmeans.cuh Outdated Show resolved Hide resolved
cpp/include/raft/cluster/detail/kmeans.cuh Outdated Show resolved Hide resolved
cpp/include/raft/cluster/detail/kmeans.cuh Outdated Show resolved Hide resolved
cpp/test/CMakeLists.txt Show resolved Hide resolved
@cjnolet
Copy link
Member

cjnolet commented Jun 1, 2022

@lowener as part of this PR process, I'd like for cuml to be using the raft version so that we don't end up with two different versions for a short time. This happened with the class labels primitives on cuml and they've since diverged, unfortunately. I'm a tad less concerned about this one if you are planning to refactor the cuml side next.

I also understand that cugraph isn't using the new formal kmeans API but as this is header-only we have seen some unexpected surprises pop up for various reasons in the past and I'd like to avoid breaking the builds for either project, even if only for a short period.

@tfeher tfeher mentioned this pull request Jun 3, 2022
10 tasks
@lowener lowener requested review from a team as code owners June 17, 2022 14:39
@cjnolet cjnolet changed the base branch from branch-22.06 to branch-22.08 June 17, 2022 14:40
@ajschmidt8 ajschmidt8 removed the request for review from a team June 21, 2022 19:04
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@cjnolet
Copy link
Member

cjnolet commented Jul 7, 2022

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Jul 26, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 563bb3f into rapidsai:branch-22.08 Jul 26, 2022
@lowener lowener deleted the 22.06-kmeans branch July 27, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review breaking Breaking change CMake cpp improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Move k-means from cuml to RAFT
3 participants