-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving kmeans from cuml to Raft #605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation is looking great so far. Most of my comments are related to small API things.
@lowener as part of this PR process, I'd like for cuml to be using the raft version so that we don't end up with two different versions for a short time. This happened with the class labels primitives on cuml and they've since diverged, unfortunately. I'm a tad less concerned about this one if you are planning to refactor the cuml side next. I also understand that cugraph isn't using the new formal kmeans API but as this is header-only we have seen some unexpected surprises pop up for various reasons in the past and I'd like to avoid breaking the builds for either project, even if only for a short period. |
Removing |
rerun tests |
@gpucibot merge |
This PR replace the current KMeans of Raft with cuml's implementation.
Closes #28.
It is using the new
device_*_view
for the API.