Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Move k-means from cuml to RAFT #28

Closed
afender opened this issue Jun 30, 2020 · 6 comments · Fixed by #605
Closed

[FEA] Move k-means from cuml to RAFT #28

afender opened this issue Jun 30, 2020 · 6 comments · Fixed by #605
Assignees
@lowener
Labels
enhancement New feature or request inactive-30d inactive-90d

Comments

@afender
Copy link
Member

afender commented Jun 30, 2020

cuML exposes a Kmeans feature. Another Kmeans implementation has been introduced as part of moving Spectral clustering to RAFT.
We should avoid multiplying implementations for the same feature.

We could move cuML's kmeans backend to RAFT and use it in spectral clustering (and potentially in cuGraph as well later on).
@afender afender added the enhancement New feature or request label Jun 30, 2020
@afender afender mentioned this issue Jun 30, 2020
Merged
@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@cjnolet
Copy link
Member

cjnolet commented Feb 24, 2022 •
edited
Loading

Prioritizing this as a 22.06 task to support cupy integration and potentially cuann work.

@cjnolet
Copy link
Member

cjnolet commented Feb 24, 2022

cc @teju85 for awareness

@cjnolet cjnolet changed the title [FEA] Reconcile kmeans implementations [FEA] Move k-means from cuml to RAFT Mar 1, 2022
@lowener lowener mentioned this issue Apr 1, 2022
Merged
@github-actions
Copy link

github-actions bot commented Apr 9, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@rapids-bot rapids-bot bot closed this as completed in #605 Jul 26, 2022
rapids-bot bot pushed a commit that referenced this issue Jul 26, 2022
@lowener
Moving kmeans from cuml to Raft (#605)
563bb3f 
This PR replace the current KMeans of Raft with cuml's implementation.
Closes #28.
It is using the new `device_*_view` for the API.

Authors:
  - Micka (https://github.com/lowener)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #605
dantegd pushed a commit to dantegd/raft that referenced this issue Jul 23, 2024
@benfred
CAGRA C-api compile fixes (rapidsai#28)
63f8d71 
The cagra_c.h file was using in-class member initializers, which are only available in c++11 - and not in C. This resulted in compile failures when trying to build C libraries using CAGRA.

Fix and add a basic C smoke test that would have caught this.

Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai/cuvs#28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowener lowener

Labels
enhancement New feature or request inactive-30d inactive-90d
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moving kmeans from cuml to Raft lowener/raft
3 participants
@cjnolet @lowener @afender