Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate sufficient memory for Hungarian if number of batches > 1 #531

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

ChuckHastings
Copy link
Contributor

Addresses Hungarian bug described in #528.

The dualUpdate method was originally using an array of size one which was eventually changed to a scalar. It really needs to be an array of size SP (number of subproblems in Date/Nagi nomenclature, number of batches as integrated into raft).

@ChuckHastings ChuckHastings requested a review from a team as a code owner February 26, 2022 23:15
@ChuckHastings ChuckHastings self-assigned this Feb 26, 2022
@github-actions github-actions bot added the cpp label Feb 26, 2022
@ChuckHastings ChuckHastings added bug Something isn't working non-breaking Non-breaking change labels Feb 26, 2022
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet
Copy link
Member

cjnolet commented Feb 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 390cf72 into rapidsai:branch-22.04 Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants