Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random ball cover in 3d #510

Merged
merged 14 commits into from
Feb 24, 2022
Merged

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 15, 2022

Todo:

  • new gtests w/ make_blobs

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 15, 2022
@cjnolet cjnolet requested review from a team as code owners February 15, 2022 23:35
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the make_blobs tests as well!

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a quick request for changes review to avoid accidental merge before static linking is done for rapidsai/cuml#4582

@cjnolet
Copy link
Member Author

cjnolet commented Feb 24, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 28fd5ef into rapidsai:branch-22.04 Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants