Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random ball cover algorithm for 3D data #4582

Merged
merged 31 commits into from
May 13, 2022
Merged

Random ball cover algorithm for 3D data #4582

merged 31 commits into from
May 13, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 15, 2022

No description provided.

@cjnolet cjnolet added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 15, 2022
@cjnolet cjnolet requested a review from a team as a code owner February 15, 2022 23:32
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 15, 2022
@cjnolet cjnolet requested a review from a team as a code owner February 15, 2022 23:44
@cjnolet
Copy link
Member Author

cjnolet commented Feb 16, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Feb 24, 2022

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Feb 25, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Apr 28, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Apr 29, 2022

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Apr 30, 2022

rerun tests

@ajschmidt8 ajschmidt8 removed the request for review from a team May 3, 2022 13:33
@cjnolet cjnolet requested a review from a team as a code owner May 3, 2022 15:40
@cjnolet
Allowing a couple mismatched indices just in the case of
e5d016e 
non-determinisms for conflicting distances
@cjnolet cjnolet mentioned this pull request May 5, 2022
Merged
@cjnolet
Copy link
Member Author

cjnolet commented May 11, 2022

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented May 12, 2022

rerun tests

dantegd
dantegd requested changes May 12, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two super minor things, otherwise it looks good!

python/cuml/neighbors/nearest_neighbors.pyx Outdated Show resolved Hide resolved
python/cuml/neighbors/nearest_neighbors.pyx Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented May 12, 2022

rerun tests

1 similar comment
@sevagh
Copy link
Contributor

sevagh commented May 12, 2022

rerun tests

@github-actions github-actions bot removed the CMake label May 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4582 (aced187) into branch-22.06 (d01c591) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.06    #4582   +/-   ##
=============================================
  Coverage         79.89%   79.89%           
=============================================
  Files               180      180           
  Lines             11371    11371           
=============================================
  Hits               9085     9085           
  Misses             2286     2286
Flag Coverage Δ
dask 45.45% <ø> (ø)
non-dask 69.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01c591...aced187. Read the comment docs.

@cjnolet
Copy link
Member Author

cjnolet commented May 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 15aba09 into rapidsai:branch-22.06 May 13, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Random ball cover algorithm for 3D data (rapidsai#4582)
1dad7b0 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjnolet @sevagh @codecov-commenter @dantegd