[WIP] Remove RAFT memory management #400
Conversation
Completes rapidsai/raft#400 Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #4468
|
@viclafargue, it looks like there's just a couple includes for |
|
Postponing to 22.04, as discussed offline. |
| #include <raft/mr/buffer_base.hpp> | ||
| #include <raft/mr/device/buffer.hpp> | ||
|
|
||
| namespace raft { |
There was a problem hiding this comment.
I believe this is going to require some updates to cugraph as well.
Completes rapidsai/raft#400 Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) URL: #2076
viclafargue
added
improvement
|
rerun tests |
viclafargue
force-pushed
the
remove-raft-memory-management
branch
from
cf19910 to
0243630
Compare
| /** Default cudaMallocHost/cudaFreeHost based host allocator */ | ||
| class default_allocator : public allocator { | ||
| public: | ||
| void* allocate(std::size_t n, cudaStream_t stream) override |
There was a problem hiding this comment.
I had tried to remove this at one point and realized cugraph is still using it. We should also open a PR in cugraph to move the use of host allocator/buffer to something equivalent.
There was a problem hiding this comment.
I just searched cugraph/cpp and could not find code calling this. We need to double check but we may have removed the code using this function.
There was a problem hiding this comment.
@seunghwak I think you are right, I'm no longer seeing it in cugraph either.
|
@gpucibot merge |
Completes rapidsai/raft#400 Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#4468
Answers #308.
Requires the appropriate changes in
cuMLandcuGraphbefore merging.