Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Remove RAFT memory management #4468

Merged
merged 8 commits into from
Jan 18, 2022
Merged

[REVIEW] Remove RAFT memory management #4468

merged 8 commits into from
Jan 18, 2022

Conversation

viclafargue
Copy link
Contributor

Completes rapidsai/raft#400

@viclafargue viclafargue requested a review from a team as a code owner January 5, 2022 15:20
@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 5, 2022
@dantegd
Copy link
Member

dantegd commented Jan 6, 2022

rerun tests

@viclafargue viclafargue changed the title Remove raft memory management [REVIEW] Remove RAFT memory management Jan 7, 2022
@viclafargue
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@ead22e0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #4468   +/-   ##
===============================================
  Coverage                ?   85.75%           
===============================================
  Files                   ?      236           
  Lines                   ?    19310           
  Branches                ?        0           
===============================================
  Hits                    ?    16560           
  Misses                  ?     2750           
  Partials                ?        0
Flag Coverage Δ
dask 46.54% <0.00%> (?)
non-dask 78.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead22e0...e2fc48b. Read the comment docs.

cjnolet
cjnolet approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great. Just one small gripe (which isn't the result of these changes and doesn't need to be fixed in this PR).

cpp/examples/symreg/symreg_example.cpp
@@ -337,8 +338,8 @@ int main(int argc, char* argv[])

/* ======================= Reset data ======================= */

raft::deallocate(d_finalprogs, stream);
curr_mr->deallocate(d_finalprogs, params.population_size, stream);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely in love with this one because it bypasses the safety of the container / buffer

Copy link
Contributor Author

@viclafargue viclafargue Jan 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! From what I remember, I believe I couldn't use the rmm::device_uvector because the type isn't trivially copyable.

@cjnolet
Copy link
Member

cjnolet commented Jan 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 091abd8 into rapidsai:branch-22.02 Jan 18, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Remove RAFT memory management (rapidsai#4468)
88d0e42 
Completes rapidsai/raft#400

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viclafargue @dantegd @codecov-commenter @cjnolet