Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new macros to scope CUDA_CHECK and CUDA_CHECK_NO_THROW for raft. #377

Closed

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Nov 15, 2021

Closes #128

@cjnolet cjnolet requested review from a team as code owners November 15, 2021 22:47
@github-actions github-actions bot added the cpp label Nov 15, 2021
@cjnolet cjnolet added bug Something isn't working non-breaking Non-breaking change labels Nov 15, 2021
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cjnolet cjnolet changed the base branch from branch-22.02 to branch-21.12 November 15, 2021 22:54
@github-actions github-actions bot added the CMake label Nov 15, 2021
@cjnolet cjnolet closed this Nov 15, 2021
@cjnolet cjnolet force-pushed the bug-2202-fix_macro_collision branch from 235a6f4 to 224e16e Compare November 15, 2021 23:14
@cjnolet
Copy link
Member Author

cjnolet commented Nov 15, 2021

Closed this PR and opened https://github.com/rapidsai/raft/pull/378/files for 21.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] RAFT header conflicts
2 participants