[BUG] RAFT header conflicts

[bryevdv]

Describe the bug
RAFT headers do not play nicely with some other RAPIDS libraries because of duplicated names

in rapids-js, just doing

include <cugraph/graph.hpp>

results in:

./../../.cache/cpm/raft/39a4ee56e5ca66c2be3eb2b78767b9d0d46759cc/cpp/include/raft/cudart_utils.h:52: error: "CUDA_TRY" redefined [-Werror]
   52 | #define CUDA_TRY(call)                                                        \
      | 
In file included from ../../../cudf/src/node_cudf/utilities/error.hpp:20,
                 from ../../../cudf/src/node_cudf/scalar.hpp:17,
                 from ../../../cudf/src/node_cudf/column.hpp:17,
                 from ../../src/node_cugraph/graph_coo.hpp:17,
                 from ../../src/graph_coo.cpp:15:
../../../.cache/cpm/cudf/6bbbff12b33dfcdeef951b16babffd1472c03bdb/cpp/include/cudf/utilities/error.hpp:102: note: this is the location of the previous definition
  102 | #define CUDA_TRY(call)                                            \
      | 

Currently to mitigate we have an internal/graph.hpp header to do this:

#ifdef CUDA_TRY
#undef CUDA_TRY
#endif
#ifdef CHECK_CUDA
#undef CHECK_CUDA
#endif
#include <cugraph/graph.hpp>
#ifdef CHECK_CUDA
#undef CHECK_CUDA
#endif
#ifdef CUDA_TRY
#undef CUDA_TRY
#endif

But it would be better if these RAPIDS tools could coordinate to avoid these clashes.

cc @trxcllnt

[github-actions]

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

[github-actions]

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

[bryevdv]

This still seems worth addressing.

[AjayThorve]

+1 Facing similar issues while building raft with cuml, for node-rapids bindings.

[cjnolet]

@bryevdv @AjayThorve @trxclln

tIs the problem here is related to conflicting names which are defined in multiple projects or are these conflicts defined only in RAFT but having problems because somehow the RAFT headers are being installed in different locations? If it's the former, I would recommend we centralize the conflicting names into RAFT (potentially prefixed w/ a RAFT specifier) to remove duplication. If the latter, we might want to consider consolidating the RAFT header installs. Any thoughts?

[bryevdv]

cc @trxcllnt

@cjnolet I assume the former. E.g. CUDA_TRY appears to be defined here in Raft:

raft/cpp/include/raft/cudart_utils.h

Line 56 in c2e5a09

#define CUDA_TRY(call) \

and here in cudf

https://github.com/rapidsai/cudf/blob/237b0ce8645bf210db791b86417781d589096d6b/cpp/include/cudf/utilities/error.hpp#L102

[jlowe]

Ran into the same problem described by @bryevdv trying to use RAFT and cuDF APIs in a compilation unit.

[cjnolet]

I will be creating a PR for this shortly, though we've agreed to add the new macros and deprecate the old ones rather than renaming. In the meantime, I will wrap the current functions w/ conditionals to test if it's been defined, though.