-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump NCCL floor to 2.19 #2458
bump NCCL floor to 2.19 #2458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks James! 🙏
One build failed with a networking error. Will wait for the rest of the builds to complete and then restart |
@jakirkham I just cancelled CI and restarted the failed jobs.
I know we're getting very close to code freeze... will leave it to @cjnolet 's discretion whether to admin-merge at some point or to wait for all those test jobs to run. I think we can be highly confident that this will work, given that the tests were all already using NCCL 2.22 on this previous successful run: https://github.com/rapidsai/raft/actions/runs/11040960166/job/30673327293 (and should continue to, given that this just moves the floor from |
Sounds good. Thanks James! 🙏 Have also mentioned this PR in the release thread offline. So it is being tracked there |
/merge |
Thanks James and Corey! 🙏 |
Follow-up to #2443
As part of the work to support NumPy 2 across RAPIDS, we found reason to upgrade some libraries like
cugraph
to slightly newer NCCL (>=2.19
). Context: rapidsai/build-planning#102 (comment)This applies that same bump here, to keep the range of NCCL versions consistent across RAPIDS.