Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump NCCL floor to 2.19 #2458

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Sep 26, 2024

Follow-up to #2443

As part of the work to support NumPy 2 across RAPIDS, we found reason to upgrade some libraries like cugraph to slightly newer NCCL (>=2.19). Context: rapidsai/build-planning#102 (comment)

This applies that same bump here, to keep the range of NCCL versions consistent across RAPIDS.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 26, 2024
@jameslamb jameslamb marked this pull request as ready for review September 26, 2024 16:48
@jameslamb jameslamb requested a review from a team as a code owner September 26, 2024 16:48
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 🙏

@jakirkham
Copy link
Member

One build failed with a networking error. Will wait for the rest of the builds to complete and then restart

@jameslamb
Copy link
Member Author

@jakirkham I just cancelled CI and restarted the failed jobs.

conda-cpp-build is upstream of a lot of other jobs, including conda-cpp-tests which can take 2-3 hours to run 😬

I know we're getting very close to code freeze... will leave it to @cjnolet 's discretion whether to admin-merge at some point or to wait for all those test jobs to run. I think we can be highly confident that this will work, given that the tests were all already using NCCL 2.22 on this previous successful run: https://github.com/rapidsai/raft/actions/runs/11040960166/job/30673327293

(and should continue to, given that this just moves the floor from >=2.18 to >=2.19)

@jakirkham
Copy link
Member

Sounds good. Thanks James! 🙏

Have also mentioned this PR in the release thread offline. So it is being tracked there

@cjnolet
Copy link
Member

cjnolet commented Sep 26, 2024

/merge

@rapids-bot rapids-bot bot merged commit 5ee0e79 into rapidsai:branch-24.10 Sep 26, 2024
74 of 75 checks passed
@jakirkham
Copy link
Member

Thanks James and Corey! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

3 participants