-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump NCCL floor to 2.18.1.1 #2443
Conversation
Updated to pull in #2453, which temporarily skips one failing test that was blocking this. |
When you have a chance James, could you please let me know what you think on this question ( rapidsai/build-planning#102 (comment) )? Asking as the answer may mean adjusting the NCCL pin |
Oh interesting that the bot merged this without a Anyway, I would have supported that anyway... as described in rapidsai/build-planning#102 and the PR description, raft is using NCCL APIs first introduced in NCCL 2.18.1 so it absolutely should have a floor of at least that version. Now that this is merged, I'll answer the question over on rapidsai/build-planning#102 @jakirkham |
A user commented |
ahhh thanks @raydouglass . All good! |
Follow-up to #2443 As part of the work to support NumPy 2 across RAPIDS, we found reason to upgrade some libraries like `cugraph` to slightly newer NCCL (`>=2.19`). Context: rapidsai/build-planning#102 (comment) This applies that same bump here, to keep the range of NCCL versions consistent across RAPIDS. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/jakirkham - Corey J. Nolet (https://github.com/cjnolet) URL: #2458
Description
Contributes to rapidsai/build-planning#102
Some RAPIDS libraries are using
ncclCommSplit()
, which was introduced innccl==2.18.1.1
. This is part of a series of PRs across RAPIDS updating libraries' pins tonccl>=2.18.1.1
to ensure they get a new-enough version that supports that.