Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] add the support of masked_matmul #2362

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

rhdong
Copy link
Member

@rhdong rhdong commented Jun 14, 2024

@rhdong rhdong requested review from benfred and cjnolet June 14, 2024 02:32
@rhdong rhdong requested review from a team as code owners June 14, 2024 02:32
@rhdong rhdong added enhancement New feature or request 3 - Ready for Review feature request New feature or request 4 - Waiting on Reviewer Waiting for reviewer to review or respond non-breaking Non-breaking change and removed CMake labels Jun 14, 2024
@github-actions github-actions bot added the CMake label Jun 29, 2024
namespace linalg {

/**
* @brief Performs a masked multiplication of dense matrices A and B, followed by an element-wise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks great, thanks @rhdong! Only one thing I can see is missing- please add this to the docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@cjnolet
Copy link
Member

cjnolet commented Jul 24, 2024

/merge

@rapids-bot rapids-bot bot merged commit ffceee2 into rapidsai:branch-24.08 Jul 24, 2024
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review 4 - Waiting on Reviewer Waiting for reviewer to review or respond CMake cpp enhancement New feature or request feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants