Enable distance return for NN Descent #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
requested changes
May 30, 2024
jinsolp
commented
Jun 3, 2024
divyegala
reviewed
Jun 4, 2024
jinsolp
force-pushed
the
fea-nndescent-api
branch
from
0e5b3d5 to
3f49752
Compare
|
/ok to test |
1 similar comment
|
/ok to test |
divyegala
reviewed
Jun 11, 2024
divyegala
reviewed
Jun 13, 2024
divyegala
approved these changes
Jun 13, 2024
divyegala
reviewed
Jun 13, 2024
|
This is no longer a breaking change |
divyegala
added
non-breaking
|
/merge |
jinsolp
changed the title
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
This make use of raft's slicing kernel within NN Descent build. I found that my previous implementation was inefficient (merged in [this PR](#2345)). ### Improvements Time to call NN Descent `build()` with `return_distances=True` before and after using this kernel | Dataset | Before |After| | ------------- | ------------- |---| | mnist (60000, 784) | 1550ms | 1020ms| | sift (1M, 128) | 11342ms |5546ms| | gist (1M, 960) | 13508ms |9278ms| Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Micka (https://github.com/lowener) URL: #2380
rapids-bot bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Nov 8, 2024
This PR is an amalgamation of the diff of 3 PRs in RAFT: 1. rapidsai/raft#2345 2. rapidsai/raft#2380 3. rapidsai/raft#2403 This PR also addresses part 1 and 2 of #419, closes #391 and makes CAGRA use the compiled headers of NN Descent, which seemed to have been a pending TODO https://github.com/rapidsai/cuvs/blob/009bb8de03ce9708d4d797166187250f77a59a36/cpp/src/neighbors/detail/cagra/cagra_build.cuh#L36-L37 Also, batch tests are disabled in this PR due to issue rapidsai/raft#2450. PR #424 will attempt to re-enable them. Authors: - Divye Gala (https://github.com/divyegala) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return_distancesflag inindex_params. When set to 1 (true), allocates a distance array to return.