Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Investigate NN Descent low recall in CUDA 12.5 and Python 3.10 wheel environment #391

Closed
divyegala opened this issue Oct 3, 2024 · 0 comments · Fixed by #421
Closed

[BUG] Investigate NN Descent low recall in CUDA 12.5 and Python 3.10 wheel environment #391

divyegala opened this issue Oct 3, 2024 · 0 comments · Fixed by #421
Labels
bug Something isn't working

Comments

@divyegala
Copy link
Member

This issue was seen when testing python HNSW wrapper API where running a single NN Descent test passes but running the whole test suite degrades the recall for some reason.
@divyegala divyegala added the bug Something isn't working label Oct 3, 2024
@divyegala divyegala mentioned this issue Oct 23, 2024
Closed
@divyegala divyegala mentioned this issue Oct 31, 2024
Merged
@rapids-bot rapids-bot bot closed this as completed in #421 Nov 8, 2024
rapids-bot bot pushed a commit that referenced this issue Nov 8, 2024
@divyegala
Migrate feature diff for NN Descent from RAFT to cuVS (#421)
29c0f5b 
This PR is an amalgamation of the diff of 3 PRs in RAFT:

1. rapidsai/raft#2345
2. rapidsai/raft#2380
3. rapidsai/raft#2403

This PR also addresses part 1 and 2 of #419, closes #391 and makes CAGRA use the compiled headers of NN Descent, which seemed to have been a pending TODO https://github.com/rapidsai/cuvs/blob/009bb8de03ce9708d4d797166187250f77a59a36/cpp/src/neighbors/detail/cagra/cagra_build.cuh#L36-L37

Also, batch tests are disabled in this PR due to issue rapidsai/raft#2450. PR #424 will attempt to re-enable them.

Authors:
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@divyegala