Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VERSION to raft-ann-bench package #2299

Merged
merged 1 commit into from
May 9, 2024
Merged

Add VERSION to raft-ann-bench package #2299

merged 1 commit into from
May 9, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

#2285 added dynamic versioning to pyproject.toml for raft-ann-bench, but did not properly copy in the VERSION file. Copy it in with tool.setuptools.package-data.

@KyleFromNVIDIA
Add VERSION to raft-ann-bench package
4ace824 
rapidsai#2285 added dynamic versioning
to pyproject.toml for raft-ann-bench, but did not properly copy in
the VERSION file. Copy it in with tool.setuptools.package-data.
@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Non-breaking change python labels May 8, 2024
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner May 8, 2024 19:28
bdice
bdice approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a test that ensures raft-ann-bench packages are importable? It seems the previous PR #2285 should've failed CI.

@KyleFromNVIDIA
Copy link
Contributor Author

Indeed, I was wondering why CI passed - simply building the wheel fails.

@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e6fe567 into rapidsai:branch-24.06 May 9, 2024
62 checks passed
abc99lr pushed a commit to abc99lr/raft that referenced this pull request May 10, 2024
@KyleFromNVIDIA @abc99lr
Add VERSION to raft-ann-bench package (rapidsai#2299)
be86b8f 
rapidsai#2285 added dynamic versioning to `pyproject.toml` for `raft-ann-bench`, but did not properly copy in the `VERSION` file. Copy it in with `tool.setuptools.package-data`.

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#2299
@jiangyinzuo jiangyinzuo mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleFromNVIDIA @bdice @divyegala