Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix VERSION FileNotFoundError in raft-ann-bench #2290

Conversation

jiangyinzuo
Copy link
Contributor

#2285 forgets to include VERSION file, causing _version.py not find VERSION file.

 rapidsai#2285 forgets to include `VERSION` file, causing _version.py not find
`VERSION` file.
@jiangyinzuo jiangyinzuo requested a review from a team as a code owner May 3, 2024 14:14
Copy link

copy-pr-bot bot commented May 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the python label May 3, 2024
@jiangyinzuo
Copy link
Contributor Author

jiangyinzuo commented May 3, 2024

The following python packaging document tells us to add a MANIFEST.in file.
https://packaging.python.org/en/latest/guides/single-sourcing-package-version/#single-sourcing-the-package-version

image

Before this commit, python3 -m raft-ann-bench.run will report the following error

Traceback (most recent call last):
  File "<frozen runpy>", line 189, in _run_module_as_main
  File "<frozen runpy>", line 112, in _get_module_details
  File "/home/jiangyinzuo/micromamba/envs/rapids_raft/lib/python3.11/site-packages/raft-ann-bench/__init__.py", line 16, in <module>
    from ._version import __git_commit__, __version__
  File "/home/jiangyinzuo/micromamba/envs/rapids_raft/lib/python3.11/site-packages/raft-ann-bench/_version.py", line 22, in <module>
    .read_text()
     ^^^^^^^^^^^
  File "/home/jiangyinzuo/micromamba/envs/rapids_raft/lib/python3.11/pathlib.py", line 1058, in read_text
    with self.open(mode='r', encoding=encoding, errors=errors) as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jiangyinzuo/micromamba/envs/rapids_raft/lib/python3.11/pathlib.py", line 1044, in open
    return io.open(self, mode, buffering, encoding, errors, newline)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/jiangyinzuo/micromamba/envs/rapids_raft/lib/python3.11/site-packages/raft-ann-bench/VERSION'

@jiangyinzuo jiangyinzuo changed the title Fix VERSION FileNotFoundError in raft-ann-bench [REVIEW] Fix VERSION FileNotFoundError in raft-ann-bench May 8, 2024
@jiangyinzuo
Copy link
Contributor Author

Solved in #2299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant