libucx should be run dependency of raft-dask
#2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
approved these changes
May 7, 2024
dantegd
approved these changes
May 7, 2024
raydouglass
approved these changes
May 7, 2024
|
/merge |
1 similar comment
|
/merge |
abc99lr
pushed a commit
to abc99lr/raft
that referenced
this pull request
May 10, 2024
As figured out in rapidsai/cuml#5697, `libucx` should not be just a testing dependency of `raft-dask`, it should be a run dependency. cc @vyasr Authors: - Divye Gala (https://github.com/divyegala) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Dante Gama Dessavre (https://github.com/dantegd) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#2296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As figured out in rapidsai/cuml#5697,
libucxshould not be just a testing dependency ofraft-dask, it should be a run dependency.cc @vyasr