Skip to content

Commit

Permalink
libucx should be run dependency of raft-dask (#2296)
Browse files Browse the repository at this point in the history
As figured out in rapidsai/cuml#5697, `libucx` should not be just a testing dependency of `raft-dask`, it should be a run dependency. 

cc @vyasr

Authors:
  - Divye Gala (https://github.com/divyegala)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Ray Douglass (https://github.com/raydouglass)

URL: #2296
  • Loading branch information
divyegala authored May 8, 2024
1 parent b760453 commit 6b731b6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ files:
table: project
includes:
- run_raft_dask
- depends_on_ucx_run
py_test_raft_dask:
output: pyproject
pyproject_dir: python/raft-dask
Expand All @@ -132,7 +133,6 @@ files:
includes:
- test_python_common
- depends_on_distributed_ucxx
- depends_on_ucx_run
py_build_raft_ann_bench:
output: pyproject
pyproject_dir: python/raft-ann-bench
Expand Down
2 changes: 1 addition & 1 deletion python/raft-dask/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ dependencies = [
"dask-cuda==24.6.*",
"joblib>=0.11",
"libraft==24.6.*",
"libucx>=1.15.0",
"numba>=0.57",
"numpy>=1.23,<2.0a0",
"pylibraft==24.6.*",
Expand All @@ -55,7 +56,6 @@ classifiers = [
[project.optional-dependencies]
test = [
"distributed-ucxx==0.38.*",
"libucx>=1.15.0",
"pytest-cov",
"pytest==7.*",
] # This list was generated by `rapids-dependency-file-generator`. To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
Expand Down

0 comments on commit 6b731b6

Please sign in to comment.