-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only install necessary components in conda packages. #2209
Only install necessary components in conda packages. #2209
Conversation
./build.sh libraft --allgpuarch --compile-lib --build-metrics=compile_lib --incl-cache-stats --no-nvtx -n | ||
cmake --install cpp/build --component compiled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now looks a lot like https://github.com/rapidsai/raft/blob/branch-24.04/conda/recipes/libraft/build_libraft_static.sh except installing the compiled
component rather than compiled-static
.
This is failing to build
|
The The hnswlib install rules in |
@robertmaynard It looks like I got the same error again. https://github.com/rapidsai/raft/actions/runs/8159304257/job/22303364726?pr=2209#step:7:3758 Can you look at the implementation (c101777) and offer guidance? |
Thanks @robertmaynard for the help in debugging! |
It looks like CI shows this, too:
|
@robertmaynard I couldn't figure out how to make the If we can figure out how to make the tests avoid building the static library, that would be a better solution. |
As of baed39a, we are packaging the right things. It may be possible to cut down the build process further (by not building This PR cuts the binary size of |
/merge |
Closes #2175.
This PR cuts the binary size of
libraft
by about 50%. In total, this PR shrinks the binary size of the entire C++ conda channel (the sum of all conda packages produced byconda/recipes/libraft/meta.yaml
) by around 20%, from 1.5 GB to 1.2 GB. The main difference is dropping the extraneous copy oflibraft.a
(~300 MB) that was shipped in thelibraft
package.