[BUG] conda libraft package includes static library #2175
Labels
bug
Something isn't working
Comments
|
Thanks @msarahan. You are correct, the libraft-static is only intended to be included in its own static conda package and should not be getting packaged up with the libraft shared library package. |
rapids-bot bot
pushed a commit
that referenced
this issue
Mar 7, 2024
Closes #2175. **This PR cuts the binary size of `libraft` by about 50%.** In total, this PR shrinks the binary size of the entire C++ conda channel (the sum of all conda packages produced by `conda/recipes/libraft/meta.yaml`) by around 20%, from 1.5 GB to 1.2 GB. The main difference is dropping the extraneous copy of `libraft.a` (~300 MB) that was shipped in the `libraft` package. Authors: - Bradley Dice (https://github.com/bdice) - Robert Maynard (https://github.com/robertmaynard) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Corey J. Nolet (https://github.com/cjnolet) - https://github.com/damontecres - Ray Douglass (https://github.com/raydouglass) URL: #2209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I'm not sure if this is truly a bug, or just a design choice that I don't understand. There is a libraft-static package, and this is where I'd expect to find the
libraft.astatic library. And it is there. The problem is that it is also in the libraft package. Since this static library is 550 MB, it leads to some pretty significant bloat when people only want the shared library.Expected behavior
I personally would remove
libraft.afrom thelibraftpackage, keeping it in libraft-static. I will put up a PR if you agree with this idea.Environment details (please complete the following information):
conda, rapidsai channel. Full package:
libraft-23.12.00-cuda12_231206_g9e2d6277_0/The text was updated successfully, but these errors were encountered: