Add compile-library by default on pylibraft build
#2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowener
added
3 - Ready for Review
non-breaking
pentschev
reviewed
Jan 11, 2024
pentschev
approved these changes
Jan 11, 2024
cjnolet
approved these changes
Jan 11, 2024
|
Thanks for fixing this @lowener. It looks like CI has some complaints about |
lowener
commented
Jan 24, 2024
|
/ok to test |
Signed-off-by: Mickael Ide <[email protected]>
|
/ok to test |
bdice
reviewed
Mar 13, 2024
|
/ok to test |
robertmaynard
requested changes
Mar 13, 2024
|
/ok to test |
|
/ok to test |
|
/ok to test |
robertmaynard
approved these changes
Mar 15, 2024
raydouglass
approved these changes
Mar 15, 2024
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 10, 2024
Partial reversion of #2090 The unintended consequence of this PR was to cause conda builds of pylibraft to rebuild libraft. As a result, since mid-24.04 we've seen the following: pylibraft conda builds have gone from 15-30 mins to 75-90 mins; pylibraft conda packages are fully repackaging libraft; and therefore, pylibraft conda packages have gone from ~2-3MB to ~300MB. A future PR may attempt to improve the developer experience again, at which point we should keep an eye out for similar regressions. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Ray Douglass (https://github.com/raydouglass) - Robert Maynard (https://github.com/robertmaynard) URL: #2300
abc99lr
pushed a commit
to abc99lr/raft
that referenced
this pull request
May 10, 2024
…i#2300) Partial reversion of rapidsai#2090 The unintended consequence of this PR was to cause conda builds of pylibraft to rebuild libraft. As a result, since mid-24.04 we've seen the following: pylibraft conda builds have gone from 15-30 mins to 75-90 mins; pylibraft conda packages are fully repackaging libraft; and therefore, pylibraft conda packages have gone from ~2-3MB to ~300MB. A future PR may attempt to improve the developer experience again, at which point we should keep an eye out for similar regressions. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Ray Douglass (https://github.com/raydouglass) - Robert Maynard (https://github.com/robertmaynard) URL: rapidsai#2300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will avoid confusion for users launching only
./build.sh pylibraft.