Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing small bug in raft-ann-bench #2041

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fixing small bug in raft-ann-bench #2041

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e79c3fa
Fixing small bug
cjnolet Dec 5, 2023
521aced
Removing unecessary print
cjnolet Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions python/raft-ann-bench/src/raft-ann-bench/run/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ def run_build_and_search(
):
for executable, ann_executable_path, algo in executables_to_run.keys():
# Need to write temporary configuration
print("ALGO: %s" % algo)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to always print this? Might be good to do logging (maybe future PR?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I just removed it. Didn't realize that was still in there

temp_conf_filename = f"{conf_filename}_{algo}_{uuid.uuid1()}.json"
with open(temp_conf_filename, "w") as f:
temp_conf = dict()
Expand Down Expand Up @@ -574,8 +575,8 @@ def add_algo_group(group_list):
index["search_params"].append(search_dict)
executables_to_run[executable]["index"].append(index)

if len(index["search_params"]) == 0:
print("No search parameters were added to configuration")
if len(index["search_params"]) == 0:
print("No search parameters were added to configuration")
Comment on lines +577 to +578
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the C++ benchmark raise an error if search params are empty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, as long as they don't then it's good. Otherwise we should be promoting the error to Python.


run_build_and_search(
conf_file,
Expand Down
Loading