Fixing small bug in raft-ann-bench #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
reviewed
Dec 5, 2023
Comment on lines
+578
to
+579
| if len(index["search_params"]) == 0: | ||
| print("No search parameters were added to configuration") |
There was a problem hiding this comment.
Will the C++ benchmark raise an error if search params are empty?
There was a problem hiding this comment.
Okay, as long as they don't then it's good. Otherwise we should be promoting the error to Python.
dantegd
reviewed
Dec 5, 2023
| @@ -154,6 +154,7 @@ def run_build_and_search( | |||
| ): | |||
| for executable, ann_executable_path, algo in executables_to_run.keys(): | |||
| # Need to write temporary configuration | |||
| print("ALGO: %s" % algo) | |||
There was a problem hiding this comment.
Do we want to always print this? Might be good to do logging (maybe future PR?)
There was a problem hiding this comment.
Good catch. I just removed it. Didn't realize that was still in there
divyegala
approved these changes
Dec 5, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.