Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for row-major slice #1591

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jun 12, 2023

Closes #1583

@lowener lowener requested a review from a team as a code owner June 12, 2023 17:03
@github-actions github-actions bot added the cpp label Jun 12, 2023
@lowener lowener added feature request New feature or request non-breaking Non-breaking change labels Jun 12, 2023
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see more APIs beind expanded for multiple layouts. Just one little comment, otherwise this LGTM!

cpp/include/raft/matrix/slice.cuh Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member

cjnolet commented Jun 23, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0db8f15 into rapidsai:branch-23.08 Jun 23, 2023
@lowener lowener deleted the 23.08-slice branch June 23, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp feature request New feature or request non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

[FEA] raft::matrix::slice to support row-major mdspans
2 participants