Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] raft::matrix::slice to support row-major mdspans #1583

Closed
cjnolet opened this issue Jun 8, 2023 · 0 comments · Fixed by #1591
Closed

[FEA] raft::matrix::slice to support row-major mdspans #1583

cjnolet opened this issue Jun 8, 2023 · 0 comments · Fixed by #1591
Assignees
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented Jun 8, 2023

This should be pretty straightforward to implement. It's possible to perform a slice on existing row-major data by constructing a column-major mdspan and then flipping the rows/cols in the slice coords but this is not particularly straightforward to the user and confusing to the user.

We should have a first-class row-major overload for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants