Unpin dask and distributed for development and fix merge_labels test
#1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raydouglass
approved these changes
Jun 5, 2023
cjnolet
approved these changes
Jun 6, 2023
galipremsagar
changed the title
dask and distributed for developmentdask and distributed for development and fix merge_labels test
|
Merged changes from #1577, to pass the CI in this PR. |
cjnolet
added
improvement
|
/merge |
|
Wow, completely confused why this pytest is suddenly failing only for a single configuration. |
Looks like third time's a charm, :phew: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unpins
daskanddistributedto>=2023.5.1for23.08development.xref: rapidsai/cudf#13508
The offending test was using an rmm::device_scalar for some memory that should have been a vector. Not sure how this didn't fail in the past but these changes fix it.