Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin dask and distributed for development #13508

Merged
merged 7 commits into from
Jun 5, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR unpins dask and distributed to >=2023.5.1 for 23.08 development.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Jun 2, 2023
@galipremsagar galipremsagar requested review from a team as code owners June 2, 2023 23:05
@galipremsagar galipremsagar self-assigned this Jun 2, 2023
@pentschev
Copy link
Member

Similar to dask-cuda, it seems that unpinning is not in effect, I think we may need to unpin Dask-CUDA first.

@galipremsagar
Copy link
Contributor Author

Similar to dask-cuda, it seems that unpinning is not in effect, I think we may need to unpin Dask-CUDA first.

Discussed with @pentschev offline and we are going to admin merge this PR to unblock rest of the unpinning & upgrade PRs.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor suggestion but otherwise LGTM. Thanks @galipremsagar !

conda/recipes/dask-cudf/run_test.sh Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs Dask Reviewer labels Jun 5, 2023
@raydouglass raydouglass merged commit 95066b0 into rapidsai:branch-23.08 Jun 5, 2023
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Jun 6, 2023
This PR unpins `dask` and `distributed` to `>=2023.5.1` for `23.08` development.


xref: rapidsai/cudf#13508

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1189
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Jun 6, 2023
… test (#1574)

This PR unpins `dask` and `distributed` to `>=2023.5.1` for `23.08` development.

xref: rapidsai/cudf#13508

The offending test was using an rmm::device_scalar for some memory that should have been a vector. Not sure how this didn't fail in the past but these changes fix it.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1574
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jun 7, 2023
This PR unpins `dask` and `distributed` to `>=2023.5.1` for `23.08` development.

xref: rapidsai/cudf#13508

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Carl Simon Adorf (https://github.com/csadorf)
  - Ray Douglass (https://github.com/raydouglass)

URL: #5452
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Jun 7, 2023
This PR unpins `dask` and `distributed` to `>=2023.5.1` for `23.08` development.

xref: rapidsai/cudf#13508

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)
  - Ray Douglass (https://github.com/raydouglass)

URL: #3634
@vyasr vyasr added dask Dask issue and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants