Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove device_resources include from linalg::map #1540

Merged
merged 5 commits into from
May 21, 2023
Merged

remove device_resources include from linalg::map #1540

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
336e2f7
remove device_resources include from linalg::map
benfred May 20, 2023
fe0c647
fix test build
benfred May 20, 2023
135c86f
Merge branch 'branch-23.06' into map_resources
benfred May 20, 2023
f1906e9
fix cagra test
benfred May 21, 2023
a7ac2d0
Merge branch 'map_resources' of github.com:benfred/raft into map_reso…
benfred May 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/include/raft/linalg/detail/map.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#pragma once

#include <raft/core/device_mdspan.hpp>
#include <raft/core/device_resources.hpp> // TODO: remove this
#include <raft/core/resource/cuda_stream.hpp>
#include <raft/core/resources.hpp>
#include <raft/util/cuda_utils.cuh>
Expand All @@ -28,6 +27,8 @@

#include <rmm/cuda_stream_view.hpp>

#include <thrust/tuple.h>

namespace raft::linalg::detail {

template <bool PassOffset, typename OutT, typename IdxT, typename Func, typename... InTs>
Expand Down
1 change: 1 addition & 0 deletions cpp/test/linalg/map.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "unary_op.cuh"
#include <gtest/gtest.h>
#include <raft/core/device_mdspan.hpp>
#include <raft/core/device_resources.hpp>
#include <raft/core/operators.hpp>
#include <raft/core/resource/cuda_stream.hpp>
#include <raft/linalg/eltwise.cuh>
Expand Down