remove device_resources include from linalg::map #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the device_resources.cuh include from linalg::map.
For the implicit integration, I don't have libraries like cusolver
in the CI environment, and the build is currently failing with
errors like
```
/project/_skbuild/linux-x86_64-3.8/cmake-build/_deps/raft-src/cpp/include/raft/core/device_resources.hpp:31:10:
fatal error: cusolverDn.h: No such file or directory
```
(from https://github.com/benfred/implicit/actions/runs/5033022104/jobs/9026999533?pr=656)
Fix by not including device_resources here
benfred
added
improvement
cjnolet
approved these changes
May 20, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the device_resources.cuh include from linalg::map.
For the implicit integration, I don't have libraries like cusolver in the CI environment, and the build is currently failing with errors like
(from https://github.com/benfred/implicit/actions/runs/5033022104/jobs/9026999533?pr=656)
Fix by not including device_resources here