-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic reduction functions and separate reductions/warp_primitives #1470
Add generic reduction functions and separate reductions/warp_primitives #1470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @akifcorduk: it's a good idea to split up cuda_utils and add tests. I have added some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akifcorduk for this work! Most of it looks good, but I have a few questions below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Akif for the updates, a few additional comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akifcorduk for addressing the issues. Apart from one issue with the right home for the new random primitives it looks good to me, therefore pre-approving.
This reverts commit f72aae8.
/merge |
This PR adds bunch of new device reduction functions such as:
There are tests implemented for all device reduction operations.
This PR also separates warp primitives to the
warp_primitives.cuh
.All reduction functions are moved to
reduction.cuh