Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrete random sampling: benchmark alternative implementation #1491

Open
tfeher opened this issue May 5, 2023 · 0 comments
Open

Discrete random sampling: benchmark alternative implementation #1491

tfeher opened this issue May 5, 2023 · 0 comments
Labels
feature request New feature or request improvement Improvement / enhancement to an existing function

Comments

@tfeher
Copy link
Contributor

tfeher commented May 5, 2023

PR #1470 adds warp / block level random sampling primitives. It is possible to have an alternative implementation that would do a full inclusive scan, and just generate one random number to pick the sample. It shall be tested which implementation is faster.

See details in discussion https://github.com/rapidsai/raft/pull/1470/files#r1185066302
@tfeher tfeher added feature request New feature or request improvement Improvement / enhancement to an existing function labels May 5, 2023
@tfeher tfeher mentioned this issue May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tfeher