Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidating ANN benchmarks and tests #1243

Merged
merged 12 commits into from
Feb 8, 2023

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 3, 2023

Consolidating types for ivf-pq, ivf-flat, and refine. Splitting ivf-flat and refine into separate files to parallelize build.

Closes #1194

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 3, 2023
@cjnolet cjnolet self-assigned this Feb 3, 2023
@cjnolet cjnolet marked this pull request as ready for review February 3, 2023 22:13
@cjnolet cjnolet requested review from a team as code owners February 3, 2023 22:13
@cjnolet cjnolet changed the base branch from branch-23.02 to branch-23.04 February 3, 2023 22:14
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Base: 87.99% // Head: 87.99% // No change to project coverage 👍

Coverage data is based on head (bac19cb) compared to base (bd0d86b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.04    #1243   +/-   ##
=============================================
  Coverage         87.99%   87.99%           
=============================================
  Files                21       21           
  Lines               483      483           
=============================================
  Hits                425      425           
  Misses               58       58           
Impacted Files Coverage Δ
python/pylibraft/pylibraft/cluster/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@cjnolet
Copy link
Member Author

cjnolet commented Feb 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit ab11cba into rapidsai:branch-23.04 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Inconsistent use of IVF-PQ specialized types
4 participants