Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inconsistent use of IVF-PQ specialized types #1194

Closed
cjnolet opened this issue Jan 26, 2023 · 1 comment · Fixed by #1243
Closed

[BUG] Inconsistent use of IVF-PQ specialized types #1194

cjnolet opened this issue Jan 26, 2023 · 1 comment · Fixed by #1243
Labels
bug Something isn't working

Comments

@cjnolet
Copy link
Member

cjnolet commented Jan 26, 2023

I noticed the IVF-PQ specializations don't seem to be getting used consistently throughout the codebase, which I think is contributing to the growing build time.

Here's the (value_t, index_t) type pairs that are being used in each source file:

Search:

  • Specializations: (float, int64_t), (float, uint32_t), (float, uint64_t)
  • Googletests: (float, int64_t)
  • Bench: (float, int64_t), (float, uint32_t), (int8_t, int64_t), (uint8_t, uint32_t)
  • Runtime: (float, uint64_t), (int8_t, uint64_t), (uint8_t, uint64_t)

Any types being used which are not being specialized are going to cause that call to be recompiled each time it is used. We should make sure we're at least specializing the union of these types if not trying to see where we can prune some out.

@cjnolet cjnolet added the bug Something isn't working label Jan 26, 2023
@cjnolet
Copy link
Member Author

cjnolet commented Jan 30, 2023

Linking #1201

@rapids-bot rapids-bot bot closed this as completed in #1243 Feb 8, 2023
rapids-bot bot pushed a commit that referenced this issue Feb 8, 2023
Consolidating types for ivf-pq, ivf-flat, and refine. Splitting ivf-flat and refine into separate files to parallelize build. 

Closes #1194

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Ben Frederickson (https://github.com/benfred)

URL: #1243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

1 participant