-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing interruptible from basic handle sync. #1224
Merged
msadang
merged 3 commits into
rapidsai:branch-23.02
from
cjnolet:bug-remove_interruptible
Feb 2, 2023
Merged
Removing interruptible from basic handle sync. #1224
msadang
merged 3 commits into
rapidsai:branch-23.02
from
cjnolet:bug-remove_interruptible
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Feb 1, 2023
divyegala
approved these changes
Feb 1, 2023
ChuckHastings
approved these changes
Feb 2, 2023
/merge |
achirkin
added a commit
to achirkin/raft
that referenced
this pull request
Feb 3, 2023
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Feb 3, 2023
… in PLC, re-enables full CI testing (#3167) closes #3124 * Adds check to avoid allocating and copying zero-length device vectors. This prevents the seg fault shown below. * Removes the special case to ignore seg faults in CI scripts * Adds a test to reproduce seg fault locally (see output below). This PR addresses the problem shown below: ``` ================================= test session starts ================================= platform linux -- Python 3.8.15, pytest-7.2.0, pluggy-1.0.0 -- /opt/conda/envs/test/bin/python3.8 cachedir: .pytest_cache rapids_pytest_benchmark: 0.0.14 benchmark: 3.2.3 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000) rootdir: /cugraph/python/pylibcugraph, configfile: pytest.ini plugins: cov-4.0.0, rapids-pytest-benchmark-0.0.14, benchmark-3.2.3 collected 9 items / 8 deselected / 1 selected python/pylibcugraph/pylibcugraph/tests/test_graph_sg.py::test_SGGraph_create_from_cudf get edgelist...edgelist = src dst wgt 0 0 1 0.0 1 1 2 0.1 2 2 4 0.2 done create Graph...done created SGGraph plc_graph=<pylibcugraph.graphs.SGGraph object at 0x7fb7e35f30f0> PASSED =========================== 1 passed, 8 deselected in 1.69s =========================== Segmentation fault (core dumped) ``` @cjnolet found a work-around for us, so this should pass CI and can be merged after rapidsai/raft#1224 Authors: - Rick Ratzel (https://github.com/rlratzel) - Chuck Hastings (https://github.com/ChuckHastings) - Corey J. Nolet (https://github.com/cjnolet) - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Chuck Hastings (https://github.com/ChuckHastings) - Brad Rees (https://github.com/BradReesWork) URL: #3167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
interruptible
seems to be causing a segfault for cugraph. We're not sure why this is only happening for cugraph yet, but the easiest fix for the release is to avoid using the interruptible when synchronizing the stream on the handle. I'll open a Github issue to investigate the crash further in 23.04.