Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing interruptible from basic handle sync. #1224

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 1, 2023

The interruptible seems to be causing a segfault for cugraph. We're not sure why this is only happening for cugraph yet, but the easiest fix for the release is to avoid using the interruptible when synchronizing the stream on the handle. I'll open a Github issue to investigate the crash further in 23.04.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 1, 2023
@cjnolet cjnolet self-assigned this Feb 1, 2023
@cjnolet cjnolet marked this pull request as ready for review February 1, 2023 23:23
@cjnolet cjnolet requested a review from a team as a code owner February 1, 2023 23:23
@github-actions github-actions bot added the cpp label Feb 1, 2023
@cjnolet
Copy link
Member Author

cjnolet commented Feb 2, 2023

/merge

@msadang msadang merged commit cd40591 into rapidsai:branch-23.02 Feb 2, 2023
achirkin added a commit to achirkin/raft that referenced this pull request Feb 3, 2023
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Feb 3, 2023
… in PLC, re-enables full CI testing (#3167)

closes #3124 

* Adds check to avoid allocating and copying zero-length device vectors.  This prevents the seg fault shown below.
* Removes the special case to ignore seg faults in CI scripts
* Adds a test to reproduce seg fault locally (see output below).

This PR addresses the problem shown below:
```
================================= test session starts =================================
platform linux -- Python 3.8.15, pytest-7.2.0, pluggy-1.0.0 -- /opt/conda/envs/test/bin/python3.8
cachedir: .pytest_cache
rapids_pytest_benchmark: 0.0.14
benchmark: 3.2.3 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /cugraph/python/pylibcugraph, configfile: pytest.ini
plugins: cov-4.0.0, rapids-pytest-benchmark-0.0.14, benchmark-3.2.3
collected 9 items / 8 deselected / 1 selected

python/pylibcugraph/pylibcugraph/tests/test_graph_sg.py::test_SGGraph_create_from_cudf
get edgelist...edgelist =     src  dst  wgt
0    0    1  0.0
1    1    2  0.1
2    2    4  0.2
done
create Graph...done
created SGGraph plc_graph=<pylibcugraph.graphs.SGGraph object at 0x7fb7e35f30f0>
PASSED

=========================== 1 passed, 8 deselected in 1.69s ===========================
Segmentation fault (core dumped)
```

@cjnolet found a work-around for us, so this should pass CI and can be merged after rapidsai/raft#1224

Authors:
  - Rick Ratzel (https://github.com/rlratzel)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Corey J. Nolet (https://github.com/cjnolet)
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Brad Rees (https://github.com/BradReesWork)

URL: #3167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

4 participants