-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes devices vector alloc to fix seg fault, removes unused RAFT code in PLC, re-enables full CI testing #3167
Fixes devices vector alloc to fix seg fault, removes unused RAFT code in PLC, re-enables full CI testing #3167
Conversation
… reproduce seg fault locally.
Codecov ReportBase: 56.26% // Head: 56.26% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3167 +/- ##
=============================================
Coverage 56.26% 56.26%
=============================================
Files 153 153
Lines 9658 9658
=============================================
Hits 5434 5434
Misses 4224 4224 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I can't request changes on my own PRs, so I added the DO NOT MERGE label so this isn't accidentally merged before commenting on if removing RAFT static linking still needs to/can be done: #3167 (comment) |
…2-py_cleanup_crash
…y linked again) for wheel builds. The change was done while debugging a crash, and is no longer needed.
Added DO NOT MERGE back until I've finished verifying it's safe to remove the RAFT sources from PLC, in the off chance CI passes even if they're needed. |
/merge |
Cancelled CI run. We need rapidsai/raft#1224 to be pushed into nightlies so that the change can be picked up by CI. |
/merge |
closes #3124
This PR addresses the problem shown below:
@cjnolet found a work-around for us, so this should pass CI and can be merged after rapidsai/raft#1224