Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balanced-k-means: fix a too large initial memory pool size #1148

Merged
merged 2 commits into from
Jan 19, 2023
Merged

balanced-k-means: fix a too large initial memory pool size #1148

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
405e66b
Limit the initial pool size
achirkin Jan 17, 2023
208e499
return mem_per_row for better handling of the workspace size
achirkin Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/include/raft/spatial/knn/detail/ann_kmeans_balanced.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022, NVIDIA CORPORATION.
* Copyright (c) 2022-2023, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -974,7 +974,9 @@ void build_hierarchical(const handle_t& handle,
rmm::mr::device_memory_resource* device_memory = nullptr;
IdxT max_minibatch_size =
calc_minibatch_size(n_clusters, n_rows, dim, metric, std::is_same_v<T, float>);
auto pool_guard = raft::get_pool_memory_resource(device_memory, max_minibatch_size * dim * 4);
auto pool_guard = raft::get_pool_memory_resource(
device_memory,
std::min<size_t>(size_t(dim * 4) * max_minibatch_size, 1000lu * 1000lu * 1000lu));
achirkin marked this conversation as resolved.
Show resolved Hide resolved
if (pool_guard) {
RAFT_LOG_DEBUG(
"kmeans::build_hierarchical: using pool memory resource with initial size %zu bytes",
Expand Down