Add L2SqrtExpanded support to ivf_flat ANN indices #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfred
added
improvement
Codecov ReportBase: 87.99% // Head: 87.99% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #1133 +/- ##
=============================================
Coverage 87.99% 87.99%
=============================================
Files 21 21
Lines 483 483
=============================================
Hits 425 425
Misses 58 58 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
achirkin
requested changes
Jan 12, 2023
achirkin
approved these changes
Jan 13, 2023
| @@ -591,9 +592,10 @@ class block_sort { | |||
| } | |||
|
|
|||
| /** Save the content by the pointer location. */ | |||
| __device__ void store(T* out, IdxT* out_idx) const | |||
| template <typename Lambda = raft::identity_op> | |||
| __device__ void store(T* out, IdxT* out_idx, Lambda post_process = raft::identity_op()) const | |||
There was a problem hiding this comment.
Just for the record: I'm currently refactoring select_k in #1085 , so I'd need to catch up with these changes there. I'm also planning to change T and IdxT into OutT and OutIdxT to allow saving the results in a type different from the working types T and IdxT.
cjnolet
approved these changes
Jan 13, 2023
|
/merge |
This was referenced Jan 15, 2023
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 15, 2023
This change was part of #1141 but was accidentally lost while merging conflicts with #1133 Authors: - Louis Sugy (https://github.com/Nyrio) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #1144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.