Adding auto-conversion configuration to pylibraft #1093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
benfred
reviewed
Dec 13, 2022
Co-authored-by: Ben Frederickson <[email protected]>
|
Closing this in favor of #1091 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a user who might already have cupy and/or pytorch installed to be able to set a configuration globally in raft to automatically convert
pylibraft.common.device_ndarrayto corresponding pytorch or cupy arrays through cuda array interface. Thist just makes the interop much easier than having to document for the users how to convert between each individual library.It would be nice if in the the future we also either added dlpack support or provided a conversion strategies for JAX and tensorflow.