Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separating more namespaces into easier-to-consume sections #1091

Merged
merged 19 commits into from
Dec 22, 2022
Merged

Separating more namespaces into easier-to-consume sections #1091

merged 19 commits into from
Dec 22, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Dec 12, 2022

No description provided.

@cjnolet cjnolet added doc Documentation non-breaking Non-breaking change labels Dec 12, 2022
@cjnolet cjnolet requested a review from a team as a code owner December 12, 2022 21:18
@github-actions github-actions bot added the cpp label Dec 12, 2022
@cjnolet cjnolet requested a review from a team as a code owner December 13, 2022 00:59
@cjnolet cjnolet mentioned this pull request Dec 13, 2022
Closed
@cjnolet cjnolet self-assigned this Dec 13, 2022
benfred
benfred approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

dantegd
dantegd approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!

README.md Show resolved Hide resolved
cpp/include/raft/core/cublas_macros.hpp Show resolved Hide resolved
docs/source/cpp_api/neighbors_ball_cover.rst Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Dec 21, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@107f6e3). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.02    #1091   +/-   ##
===============================================
  Coverage                ?   87.68%           
===============================================
  Files                   ?       20           
  Lines                   ?      471           
  Branches                ?        0           
===============================================
  Hits                    ?      413           
  Misses                  ?       58           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member Author

cjnolet commented Dec 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a67a1db into rapidsai:branch-23.02 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@benfred benfred benfred approved these changes

Assignees

@cjnolet cjnolet

Labels
cpp doc Documentation non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjnolet @codecov-commenter @benfred @dantegd