-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Implement new API functions using mdspan
#535
Labels
Comments
This issue has been labeled |
cjnolet
changed the title
[FEA] Implement new API functions using
[FEA] Implement new API functions using new May 20, 2022
device_*_view
mdspan
API
cjnolet
changed the title
[FEA] Implement new API functions using new
[FEA] Implement new API functions using May 20, 2022
mdspan
APImdspan
mhoemmen
added a commit
to mhoemmen/raft
that referenced
this issue
Sep 7, 2022
Add an overload of make_regression that takes mdspan, instead of raw pointers. The overload does not increase generality (e.g., it still requires row-major mdspan). Part of rapidsai#535.
mhoemmen
added a commit
to mhoemmen/raft
that referenced
this issue
Sep 7, 2022
Add an overload of make_regression that takes mdspan, instead of raw pointers. The overload does not increase generality (e.g., it still requires row-major mdspan). Part of rapidsai#535.
rapids-bot bot
pushed a commit
that referenced
this issue
Sep 9, 2022
Add an overload of `make_regression` that takes mdspan, instead of raw pointers. The overload does not increase generality (e.g., it still requires row-major mdspan). Part of #535. Authors: - Mark Hoemmen (https://github.com/mhoemmen) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #811
rapids-bot bot
pushed a commit
that referenced
this issue
Oct 7, 2022
Part of #535. Implementation of the raft::stats API with mdspan, with the C++ tests 14/22 Files implemented. The remaining files will come in a following PR. Authors: - Micka (https://github.com/lowener) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #802
Repository owner
moved this from In Progress
to Done
in VS/ML/DM Primitives Release Board
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Now that we have
mdspan
andmdarray
in RAFT, we are able to start implementing our new public API contract facades with them.To start, we can add new functions that assume the underlying layouts are contiguous, deprecate the old functions, and then as we iterate on the
mdspan
andmdarray
and use them in more in device functions, we can eventually support non-contiguous layouts.Ideally we would be consistent about the ordering of arguments to the new functions. We should start using
std::optional
for any optional arguments (instead of null pointers) and perhaps follow Thrust's format of accepting inputs before outputs (raft handle should always be the first argument).Namespaces to add the new functions:
It might also make sense to break these up so different people can take on a couple namespaces. This could help 1) more developers getting quickly spun up on mdarray/mdspan, and 2) getting these knocked out more quickly while folks are able to work on different parts concurrently.
This issue will also close #360
The text was updated successfully, but these errors were encountered: