Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Clean up ctk lib "wrapper" calls in cuml #475

Open
cjnolet opened this issue Feb 1, 2022 · 4 comments
Open

[TASK] Clean up ctk lib "wrapper" calls in cuml #475

cjnolet opened this issue Feb 1, 2022 · 4 comments
Labels
bug Something isn't working inactive-30d inactive-90d

Comments

@cjnolet
Copy link
Member

cjnolet commented Feb 1, 2022

We've been moving the wrapper functions for the ctk libraries into detail so that we can better manage the RAFT API functions which are being invoked by consuming projects.

Step 1 was to hide the wrapper functions in the detail namespace and Step 2 is to re-route all calls to functions in detail from downstream projects so they are calling into the public API.

Additionally, the cublas wrapper functions in linalg have any unnecessary overloads, which can be consolidated. These will also need to continue to provide the option of accepting device or host pointers for scalar parameters alpha and beta, in which the new device_scalar_view will be useful.

@cjnolet cjnolet added the bug Something isn't working label Feb 1, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Feb 1, 2022

Linking rapidsai/cuml#4547 and rapidsai/cuml#4515

@cjnolet
Copy link
Member Author

cjnolet commented Mar 1, 2022

This is probably best done once we've completed the movement of primitives from cuml.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working inactive-30d inactive-90d
Projects
Status: No status
Development

No branches or pull requests

1 participant