Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating RAFT linalg headers #4515

Merged
merged 12 commits into from
Feb 8, 2022
Merged

Updating RAFT linalg headers #4515

merged 12 commits into from
Feb 8, 2022

Conversation

divyegala
Copy link
Member

Depends on rapidsai/raft#383

@divyegala divyegala requested review from a team as code owners January 25, 2022 02:38
@divyegala divyegala changed the base branch from branch-22.02 to branch-22.04 January 25, 2022 02:38
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ gpuCI gpuCI issue labels Jan 25, 2022
@divyegala divyegala removed the request for review from a team January 25, 2022 02:39
@divyegala divyegala added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed CMake gpuCI gpuCI issue conda conda issue labels Jan 25, 2022
cjnolet
cjnolet requested changes Jan 26, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor things (also pending copyright updates, which the style checks found).

cpp/bench/prims/gram_matrix.cu Show resolved Hide resolved
cpp/cmake/thirdparty/get_raft.cmake Outdated
FORK rapidsai
PINNED_TAG branch-${CUML_BRANCH_VERSION_raft}
FORK divyegala
PINNED_TAG imp-21.12-linalg_detail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to change back

@github-actions github-actions bot added the CMake label Jan 27, 2022
@github-actions github-actions bot added the gpuCI gpuCI issue label Jan 27, 2022
@divyegala
Copy link
Member Author

rerun tests

1 similar comment
@cjnolet
Copy link
Member

cjnolet commented Jan 28, 2022

rerun tests

@divyegala divyegala requested a review from a team as a code owner February 1, 2022 01:09
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 1, 2022
@cjnolet
Copy link
Member

cjnolet commented Feb 1, 2022

rerun tests

@cjnolet cjnolet mentioned this pull request Feb 1, 2022
Open
@divyegala
Copy link
Member Author

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Feb 2, 2022

rerun tests

3 similar comments
@cjnolet
Copy link
Member

cjnolet commented Feb 3, 2022

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Feb 3, 2022

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Feb 3, 2022

rerun tests

@divyegala
Copy link
Member Author

rerun tests

1 similar comment
@divyegala
Copy link
Member Author

rerun tests

@github-actions github-actions bot removed gpuCI gpuCI issue CMake labels Feb 8, 2022
cjnolet
cjnolet approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@b983274). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4515   +/-   ##
===============================================
  Coverage                ?   85.71%           
===============================================
  Files                   ?      236           
  Lines                   ?    19365           
  Branches                ?        0           
===============================================
  Hits                    ?    16599           
  Misses                  ?     2766           
  Partials                ?        0
Flag Coverage Δ
dask 46.48% <0.00%> (?)
non-dask 78.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b983274...37e1ba9. Read the comment docs.

@cjnolet
Copy link
Member

cjnolet commented Feb 8, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f95e93b into rapidsai:branch-22.04 Feb 8, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@divyegala
Updating RAFT linalg headers (rapidsai#4515)
94166bc 
Depends on rapidsai/raft#383

Authors:
  - Divye Gala (https://github.com/divyegala)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyegala @cjnolet @codecov-commenter