Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAFT API updates for lap, label, cluster, and spectral apis #4548

Merged
merged 6 commits into from
Feb 9, 2022
Merged

RAFT API updates for lap, label, cluster, and spectral apis #4548

merged 6 commits into from
Feb 9, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 1, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 1, 2022
@cjnolet cjnolet requested a review from a team as a code owner February 1, 2022 23:32
@github-actions github-actions bot added the CMake label Feb 1, 2022
@cjnolet cjnolet requested a review from a team as a code owner February 2, 2022 00:22
dantegd
dantegd requested changes Feb 3, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good

cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Feb 3, 2022

rerun tests

@github-actions github-actions bot removed the CMake label Feb 9, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Feb 9, 2022

@dantegd there's an issue in RAFT for this: rapidsai/raft#475. However, one reason I'm not particularly concerned with them is because just about all of them are in primitives which we are already planning to move to RAFT. Once those are moved over, the remaining code in cuml will no longer be calling functions in the raft detail namespace.

@cjnolet
Copy link
Member Author

cjnolet commented Feb 9, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@7e7832d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4548   +/-   ##
===============================================
  Coverage                ?   85.70%           
===============================================
  Files                   ?      236           
  Lines                   ?    19363           
  Branches                ?        0           
===============================================
  Hits                    ?    16596           
  Misses                  ?     2767           
  Partials                ?        0
Flag Coverage Δ
dask 46.46% <0.00%> (?)
non-dask 78.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e7832d...bb3fad4. Read the comment docs.

@jjacobelli
Copy link
Contributor

rerun tests

@cjnolet cjnolet mentioned this pull request Feb 9, 2022
Merged
@dantegd
Copy link
Member

dantegd commented Feb 9, 2022

@gpucibot merge

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Feb 9, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9b52960 into rapidsai:branch-22.04 Feb 9, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
RAFT API updates for lap, label, cluster, and spectral apis (rapidsai…
e283b7b 
…#4548)

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjnolet @codecov-commenter @jjacobelli @dantegd