-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Update cuSparse deprecated calls #289
Comments
This PR fixes current RAFT C++/CUDA compilation warnings and turns on -Wall to treat warnings as errors. Fixes #225 Fixes #289 Authors: - Mark Harris (https://github.com/harrism) Approvers: - Brad Rees (https://github.com/BradReesWork) - Corey J. Nolet (https://github.com/cjnolet) URL: #299
Closed by #299 |
I am still seeing the warnings... Are these really fixed? |
The referenced PR only fixed warnings that appear in building raft itself. The warnings cugraph is getting are from deprecated calls in raft that aren't used in the raft test code. Is there a plan to update the cusparse calls to eliminate these? |
Note that Line 48 in e806f99
ON to OFF you will see the deprecation warnings when building raft that we are seeing when building cugraph.
|
This issue has been labeled |
Digging through the cugraph code a bit, it looks like the only reason these warnings are triggered at all is because the |
It looks like the only deprecated function we are actually calling within RAFT is |
Closes #289 Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Jiaming Yuan (https://github.com/trivialfis) - Chuck Hastings (https://github.com/ChuckHastings) - Seunghwa Kang (https://github.com/seunghwak) URL: #441
Describe the bug
Compiling with raft produces the following many wanrings.
The text was updated successfully, but these errors were encountered: