-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Build RAFT tests with -Wall -Werror
#225
Labels
bug
Something isn't working
Comments
I started this as a feature-request, but realized it's better as a bug. That's why the label is wrong. |
dantegd
added
bug
Something isn't working
and removed
feature request
New feature or request
labels
May 12, 2021
PR #187 adds the cmake side to enable this easily, was going to push it in the same PR but (as usual) once I fix what it looked like a single warning, more started popping up, so it probably needs to be a follow up. |
Merged
rapids-bot bot
pushed a commit
that referenced
this issue
Jul 28, 2021
This PR fixes current RAFT C++/CUDA compilation warnings and turns on -Wall to treat warnings as errors. Fixes #225 Fixes #289 Authors: - Mark Harris (https://github.com/harrism) Approvers: - Brad Rees (https://github.com/BradReesWork) - Corey J. Nolet (https://github.com/cjnolet) URL: #299
Closed nu #299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a header-only library, warnings in RAFT can cause errors in consuming libs that compile with
-Werror
. Building tests with-Wall -Werror
like RMM does should catch most problems before they're released.For example, see this error in a RAFT header when compiling cuML:
The text was updated successfully, but these errors were encountered: