Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAFT: CUDA 12 Conda Packages #1278

Closed
14 tasks done
Tracked by #5234
, #3271
...
jakirkham opened this issue Feb 14, 2023 · 9 comments · Fixed by #1388
Closed
14 tasks done
Tracked by #5234
, #3271
...

RAFT: CUDA 12 Conda Packages #1278

jakirkham opened this issue Feb 14, 2023 · 9 comments · Fixed by #1388
Assignees
@cjnolet

Comments

@jakirkham
Copy link
Member

jakirkham commented Feb 14, 2023 •
edited
Loading

Pushing for CUDA 12 Conda package builds of libraries for RAPIDS 23.04. This issue is for tracking that work.

Requirements (please recheck):

Developer tasks
Preview Give feedback

Toolkit dependencies from Conda
Preview Give feedback
  1. Adding cuda-cudart conda-forge/staged-recipes#21723
    review-requested staged-recipes
  2. Adding cuda-nvcc recipe conda-forge/staged-recipes#21350
  3. Adding cuda-profiler-api recipes conda-forge/staged-recipes#22125
  4. Adding cuda-nvtx recipe conda-forge/staged-recipes#22052
  5. Add libcublas recipe conda-forge/staged-recipes#21901
    review-requested staged-recipes
  6. Add libcurand recipe conda-forge/staged-recipes#21916
  7. Add libcusolver, libcusparse, and libnvjitlink recipes conda-forge/staged-recipes#21924
    review-requested staged-recipes
  8. Adding cuda-cccl recipe conda-forge/staged-recipes#21953
    review-requested staged-recipes

RAPIDS Conda dependencies
Preview Give feedback
  1. RMM: CUDA 12 Conda Packages rmm#1207
    6 of 6
    bdice

Other dependencies from Conda using CUDA
Preview Give feedback
  1. NCCL: Support CUDA 12 conda-forge/nccl-feedstock#82
  2. UCX: Support CUDA 12 conda-forge/ucx-split-feedstock#116

Deprecated dependencies from Conda using CUDA ( please see PR #1202 )
Preview Give feedback
  1. Faiss: Support CUDA 12 conda-forge/faiss-split-feedstock#65

Test only dependencies from Conda using CUDA
Preview Give feedback
  1. CuPy: Support CUDA 12 conda-forge/cupy-feedstock#139
@bdice
Copy link
Contributor

bdice commented Feb 14, 2023 •
edited
Loading

cuda-cccl is not a dependency for any RAPIDS packages. RAPIDS usually uses newer (and sometimes patched) versions of CCCL fetched by rapids-cmake, and won't be needing the cuda-cccl packages.

@bdice
Copy link
Contributor

bdice commented Feb 14, 2023

All the math libraries will require -dev packages. e.g. libcublas-dev as well as libcublas. We list the -dev packages as runtime requirements in libraft-headers so that other packages can build against it.

@bdice
Copy link
Contributor

bdice commented Feb 14, 2023

Also needs nccl and ucx with CUDA support listed somewhere.

@jakirkham
Copy link
Member Author

For now will leave cuda-cccl just so we know it is used in some form. How exactly we handled that we can follow up after the general discussion around it has settled.

Good to know about -dev packages being used at runtime. The -dev packages are produced out of a split package that also produces the dynamic & static library packages. So knowing one of them is needed is sufficient. We can take a closer look when it comes time to rebuild.

Thanks for reminding me 🙏 Had forgotten these 🤦‍♂️ They are now in the other dependencies list.

@cjnolet
Copy link
Member

cjnolet commented Feb 16, 2023 •
edited
Loading

I agree w/ @bdice, we don't explicitly depend on anything from cuda-cccl currently. The faiss dependency will also be going away shortly (definitely in 23.04) w/ this pr

@jakirkham
Copy link
Member Author

Thanks Corey! 🙏

Since cuda-nvcc is going to depend on cuda-cccl, am going to leave it.

Noted that faiss is going away, but have left that item in the list for now. Believe merging that PR should check that box, but we can do this manually if that ends up being needed.

This was referenced Feb 23, 2023
Closed
Closed
@cjnolet
Copy link
Member

cjnolet commented Feb 27, 2023

@jakirkham this LGTM. Just looked back through the dependencies to verify. cupy is only a test dependency and everything else is covered.

@bdice
Copy link
Contributor

bdice commented Mar 17, 2023

Working on builds with the nvidia channel here: #1353

@jakirkham
Copy link
Member Author

Current work using nvidia channel packages in PR ( #1388 )

@jakirkham jakirkham changed the title CUDA 12 Conda Packages RAFT: CUDA 12 Conda Packages Apr 7, 2023
@jarmak-nv jarmak-nv mentioned this issue Jun 27, 2023
Merged
@rapids-bot rapids-bot bot closed this as completed in #1388 Jul 5, 2023
rapids-bot bot pushed a commit that referenced this issue Jul 5, 2023
@vyasr
raft: Build CUDA 12 packages (#1388)
32b3dba 
First attempt at building libraft with CUDA 12

Closes #1278

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Corey J. Nolet (https://github.com/cjnolet)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Tamas Bela Feher (https://github.com/tfeher)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Ray Douglass (https://github.com/raydouglass)
  - https://github.com/jakirkham
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjnolet cjnolet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

raft: Build CUDA 12 packages vyasr/raft
3 participants
@cjnolet @jakirkham @bdice