Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cuda-profiler-api recipes #22125

Merged
merged 12 commits into from
Apr 18, 2023
Merged

Adding cuda-profiler-api recipes #22125

merged 12 commits into from
Apr 18, 2023

Conversation

adibbley
Copy link
Contributor

@adibbley adibbley commented Feb 23, 2023 •
edited
Loading

xref: #21382

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-profiler-api) and found some lint.

Here's what I've got...

For recipes/cuda-profiler-api:

  • The recipe must have some tests.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/cuda-profiler-api) and found it was in an excellent condition.

@adibbley
Copy link
Contributor Author

cc @jakirkham

@jakirkham jakirkham mentioned this pull request Feb 23, 2023
Closed
@adibbley adibbley mentioned this pull request Feb 23, 2023
Closed
49 tasks
This was referenced Feb 27, 2023
Closed
Closed
bdice
bdice reviewed Mar 22, 2023
View reviewed changes
recipes/cuda-profiler-api/meta.yaml Show resolved Hide resolved
recipes/cuda-profiler-api/meta.yaml Outdated Show resolved Hide resolved
bdice
bdice reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recipe looks fine aside. I haven't checked the package contents yet.

@adibbley adibbley marked this pull request as ready for review April 12, 2023 22:14
@jakirkham jakirkham requested a review from bdice April 13, 2023 07:31
vyasr
vyasr reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of open questions, nothing blocking from me but Rob's questions look like they do need to be addressed before we can merge.

recipes/cuda-profiler-api/build.sh Outdated Show resolved Hide resolved
recipes/cuda-profiler-api/meta.yaml Show resolved Hide resolved
@vyasr vyasr mentioned this pull request Apr 13, 2023
Merged
10 tasks
bdice
bdice reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor updates suggested.

recipes/cuda-profiler-api/build.sh Outdated Show resolved Hide resolved
recipes/cuda-profiler-api/meta.yaml Show resolved Hide resolved
recipes/cuda-profiler-api/meta.yaml Outdated Show resolved Hide resolved
@jakirkham jakirkham requested review from bdice and kkraus14 and removed request for bdice April 14, 2023 22:09
@jakirkham jakirkham requested a review from bdice April 15, 2023 00:23
bdice
bdice approved these changes Apr 15, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. 😄

jakirkham
jakirkham reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion to improve the URLs here based on feedback

recipes/cuda-profiler-api/meta.yaml Show resolved Hide resolved
recipes/cuda-profiler-api/meta.yaml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's follow up on anything else in the feedstock 🙂

@jakirkham jakirkham merged commit 1e68020 into conda-forge:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@vyasr vyasr vyasr left review comments

@leofang leofang leofang approved these changes

@bdice bdice bdice approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adibbley @jakirkham @robertmaynard @vyasr @kkraus14 @bdice @leofang