Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.7 #42

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Release 0.1.7 #42

merged 1 commit into from
Jan 13, 2024

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham requested a review from a team as a code owner January 12, 2024 20:47
@jakirkham
Copy link
Member Author

cc @vyasr

@bdice
Copy link
Contributor

bdice commented Jan 13, 2024

@jakirkham Will you create the tag after merging? I’m not sure who has permissions for that. If you don’t, I can try it.

@jakirkham
Copy link
Member Author

I'm happy to try

@jakirkham jakirkham merged commit 9765e2b into rapidsai:main Jan 13, 2024
32 checks passed
@jakirkham jakirkham deleted the rel_0.1.7 branch January 13, 2024 00:53
@jakirkham
Copy link
Member Author

Have made a tag locally. Just trying to test it out before attempting to push

@jakirkham
Copy link
Member Author

Ok have pushed the tag for v0.1.7

Here are the builds

@jakirkham
Copy link
Member Author

jakirkham commented Jan 13, 2024

Looks like the packages built ok (and they do show up here), but not sure about the upload. It shows as passed, but see this line

jq: error (at <unknown>): Cannot iterate over null (null)

Is there something we are missing?

AJ mentioned some changes to the build-conda section here ( #33 (comment) ). Though build-wheels didn't have those changes; whereas, both publish-conda and publish-wheels had those pieces already. Perhaps I'm misunderstanding something about that suggestion though

Are there other things we might be missing? Maybe environment variables we need?

@jakirkham
Copy link
Member Author

Think build-conda's build_type was getting set to pull-request when it should have been set to branch (like what build-wheel does). Fixing with PR ( #43 )

@jakirkham
Copy link
Member Author

jakirkham commented Jan 16, 2024

Looks like the build_type change was the missing piece

Also just noticed that there was another hard-coded version floating around in the codebase that was missed in this PR

We should really consolidate these into one place (or ideally none and pickup from the tag or otherwise automate)

For now fixing the version bump on that file as part of PR ( #44 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants