Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set pipefail in wheel build scripts #34

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Set pipefail in wheel build scripts #34

merged 4 commits into from
Jan 5, 2024

Conversation

brandon-b-miller
Copy link
Contributor

@brandon-b-miller brandon-b-miller commented Jan 5, 2024 •
edited
Loading

This PR fixes up some CI scripts to actually fail if something goes wrong, as well as some other minor cleanup.

Closes #32

@brandon-b-miller brandon-b-miller marked this pull request as ready for review January 5, 2024 16:56
@bdice
Copy link
Contributor

bdice commented Jan 5, 2024

Failing on errors unveiled a lot of issues in the build script! All fixed now. I'm going to merge this to unblock further work on #33.

@bdice bdice merged commit ce20b81 into rapidsai:main Jan 5, 2024
@jakirkham jakirkham mentioned this pull request Jan 12, 2024
Merged
jakirkham added a commit that referenced this pull request Jan 13, 2024
@jakirkham
Release 0.1.7 (#42)
9765e2b 
* Add Conda packages and CI workflows (#33)
* Set pipefail in wheel build scripts (#34)
* [REVIEW] remove references to setup.py in docs (#36)
* Update README.md (#37)
* Remove usages of rapids-env-update (#41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build_wheel.sh needs to stop on error
2 participants
@brandon-b-miller @bdice